-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47159/
-----------------------------------------------------------

(Updated May 10, 2016, 12:25 p.m.)


Review request for lens.


Bugs: lens-1032
    https://issues.apache.org/jira/browse/lens-1032


Repository: lens


Description
-------

Right now, on execute with timeout api, if the query times out, then query will 
be still running for people to pull reports.

We should provide option to kill the query upon timeout for users who are not 
interested in result beyond timeout.

Chnages
------
Added  property lens.query.cancel.on.timeout (default = true )
Added queryCancellationPool to Query Service to cancel queries asynchronously
Updated Timeout logic in QueryExecutionServiceImpl#executeTimeoutInternal
HiveDriver : updated check interval for completion listener . Minumum interval 
is 5 secs now.


Diffs
-----

  lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 67d1e79 
  lens-client/src/main/resources/lens-client-default.xml 96506ac 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
1463cc2 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
7cf6449 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 b12943e 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java
 a043550 
  lens-server/src/main/resources/lenssession-default.xml ce296cc 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
62c0280 
  src/site/apt/admin/session-config.apt 206d6a4 

Diff: https://reviews.apache.org/r/47159/diff/


Testing (updated)
-------

org.apache.lens.server.query.TestQueryService#testAutoCancelOnTimeOut  : Pass

**Was able to run the entire build** 
INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.995s]
[INFO] Lens .............................................. SUCCESS [2.736s]
[INFO] Lens API .......................................... SUCCESS [20.816s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.360s]
[INFO] Lens Cube ......................................... SUCCESS [15:25.456s]
[INFO] Lens DB storage ................................... SUCCESS [16.204s]
[INFO] Lens Query Library ................................ SUCCESS [12.302s]
[INFO] Lens Hive Driver .................................. SUCCESS [1:23.937s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.370s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [19.032s]
[INFO] Lens Server ....................................... SUCCESS [8:29.861s]
[INFO] Lens client ....................................... SUCCESS [1:30.514s]
[INFO] Lens CLI .......................................... SUCCESS [1:23.783s]
[INFO] Lens Examples ..................................... SUCCESS [8.504s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.618s]
[INFO] Lens Distribution ................................. SUCCESS [9.448s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:06.958s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.232s]
[INFO] Lens Regression ................................... SUCCESS [11.566s]
[INFO] Lens UI ........................................... SUCCESS [43.459s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32:46.852s


Thanks,

Puneet Gupta

Reply via email to