> On Feb. 22, 2016, 7:31 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/LensServer.java, line 117 > > <https://reviews.apache.org/r/43765/diff/2/?file=1259207#file1259207line117> > > > > Will it mask `LensExceptionMapper` since `LensExceptionMapper extends > > ExceptionMapper<LensException>` and `GenericErrorMapper extends > > ExceptionMapper<Throwable>` and `Throwable` is `super` class to > > `LensException`? > > > > If it does, it's better to keep just one exception mapper in our code > > that has a special handling for `LensException`
It wont mask. But I'm thinking to merge the exceptionmapper into one. > On Feb. 22, 2016, 7:31 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/error/GenericErrorMapper.java, > > line 34 > > <https://reviews.apache.org/r/43765/diff/2/?file=1259208#file1259208line34> > > > > Let's make it `GenericExceptionMapper` to conform with other names like > > `LensExceptionMapper` and `ExceptionMapper` I'm planning to change from ExceptionMapper<Throwable> to ExceptionMapper<Exception> - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43765/#review120123 ----------------------------------------------------------- On Feb. 19, 2016, 2:13 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43765/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 2:13 p.m.) > > > Review request for lens. > > > Bugs: LENS-957 > https://issues.apache.org/jira/browse/LENS-957 > > > Repository: lens > > > Description > ------- > > Added GenericErrorMapper which can map all non LensExcpeption to Internal > server error and put the output out. > > > Diffs > ----- > > lens-server/src/main/java/org/apache/lens/server/LensServer.java 092ecda > > lens-server/src/main/java/org/apache/lens/server/error/GenericErrorMapper.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java > 4d4f137 > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > 2f74ceb > > lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java > 0e39b52 > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 30f7aff > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 699fa68 > > lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java > 70e2dbc > > Diff: https://reviews.apache.org/r/43765/diff/ > > > Testing > ------- > > Not all tests passing. Needs more on looking into failures. > > > Thanks, > > Amareshwari Sriramadasu > >
