> On May 12, 2016, 1:19 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/error/GenericExceptionMapper.java, > > line 63 > > <https://reviews.apache.org/r/43765/diff/3/?file=1379715#file1379715line63> > > > > Can we check for return type instead? This will grow as we change other > > APIs to return LensAPIResult.
This might be helpful: http://stackoverflow.com/questions/7402288/get-handler-from-uri-in-jersey - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43765/#review132841 ----------------------------------------------------------- On May 11, 2016, 8:57 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43765/ > ----------------------------------------------------------- > > (Updated May 11, 2016, 8:57 p.m.) > > > Review request for lens. > > > Bugs: LENS-957 > https://issues.apache.org/jira/browse/LENS-957 > > > Repository: lens > > > Description > ------- > > Added GenericExceptionMapper which can map all non LensExcpeption to Internal > server error and put the output out. > > > Diffs > ----- > > lens-server/src/main/java/org/apache/lens/server/LensServer.java 092ecda > > lens-server/src/main/java/org/apache/lens/server/error/GenericExceptionMapper.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/error/LensExceptionMapper.java > 1bb65ca > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > a043550 > > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java > 861600c > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 7c17b8a > > lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java > 3ede853 > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > 2f74ceb > > lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java > 837c33d > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 29fcd6d > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 62c0280 > > lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java > f9bacf1 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 988fa1d > > Diff: https://reviews.apache.org/r/43765/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.895s] > [INFO] Lens .............................................. SUCCESS [3.355s] > [INFO] Lens API .......................................... SUCCESS [21.464s] > [INFO] Lens API for server and extensions ................ SUCCESS [17.594s] > [INFO] Lens Cube ......................................... SUCCESS > [16:27.338s] > [INFO] Lens DB storage ................................... SUCCESS [17.493s] > [INFO] Lens Query Library ................................ SUCCESS [13.184s] > [INFO] Lens Hive Driver .................................. SUCCESS [1:23.188s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [35.589s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.243s] > [INFO] Lens Server ....................................... SUCCESS [8:30.095s] > [INFO] Lens client ....................................... SUCCESS [1:35.534s] > [INFO] Lens CLI .......................................... SUCCESS [1:23.709s] > [INFO] Lens Examples ..................................... SUCCESS [9.743s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.618s] > [INFO] Lens Distribution ................................. SUCCESS [9.474s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:10.219s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.119s] > [INFO] Lens Regression ................................... SUCCESS [10.551s] > [INFO] Lens UI ........................................... SUCCESS [41.184s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 33:56.476s > [INFO] Finished at: Wed May 11 13:38:16 UTC 2016 > [INFO] Final Memory: 193M/2639M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >
