----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47007/#review132891 -----------------------------------------------------------
We might have to disable this feature for test (in lens-server/src/test/resources/lens-site.xml). Many test cases fire the same query in same session and rely on it to create multiple queries in server. - Puneet Gupta On May 12, 2016, 10:05 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47007/ > ----------------------------------------------------------- > > (Updated May 12, 2016, 10:05 a.m.) > > > Review request for lens. > > > Bugs: LENS-1019 > https://issues.apache.org/jira/browse/LENS-1019 > > > Repository: lens > > > Description > ------- > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. This > will only handle the case of aysnc queries. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 7cf6449 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 2a11f97 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > b12943e > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > 900770b > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > a6c7b13 > lens-server/src/main/resources/lensserver-default.xml 9580397 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 62c0280 > src/site/apt/admin/config.apt 4bf1e7c > > Diff: https://reviews.apache.org/r/47007/diff/ > > > Testing > ------- > > testExecuteAsyncDuplicate() methods tests the following. > 1. Same query, same user and same session returns the same handle. > 2. After query completion, same query firing will give the different handle. > 3. Differnt session and same query will return different handle. > > > Thanks, > > Lavkesh Lahngir > >
