----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47007/#review132635 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 183) <https://reviews.apache.org/r/47007/#comment196901> Should we chnage the name to keep it in sync with property name ? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1310) <https://reviews.apache.org/r/47007/#comment196902> Do we need to call removeFromActiveQueries() in this case ? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1806) <https://reviews.apache.org/r/47007/#comment196903> executePrepareAsync() needs to be handled for duplicate query. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1814) <https://reviews.apache.org/r/47007/#comment196904> can we update cachedHandle variable name and log message as per the new property name lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1841) <https://reviews.apache.org/r/47007/#comment196905> small Typo in method name lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1844) <https://reviews.apache.org/r/47007/#comment196906> Synchronize based on session ? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1845) <https://reviews.apache.org/r/47007/#comment196908> We may get ConcurrentModificationException if add or remove active queries is called on LensSessionImpl. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1847) <https://reviews.apache.org/r/47007/#comment196907> First session check is not required - Puneet Gupta On May 10, 2016, 1:59 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47007/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 1:59 p.m.) > > > Review request for lens. > > > Bugs: LENS-1019 > https://issues.apache.org/jira/browse/LENS-1019 > > > Repository: lens > > > Description > ------- > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. This > will only handle the case of aysnc queries. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 7cf6449 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 2a11f97 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > b12943e > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > 900770b > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > a6c7b13 > lens-server/src/main/resources/lensserver-default.xml 9580397 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 62c0280 > > Diff: https://reviews.apache.org/r/47007/diff/ > > > Testing > ------- > > testExecuteAsyncDuplicate() methods tests the following. > 1. Same query, same user and same session returns the same handle. > 2. After query completion, same query firing will give the different handle. > 3. Differnt session and same query will return different handle. > > > Thanks, > > Lavkesh Lahngir > >
