----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47454/#review133538 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 2399) <https://reviews.apache.org/r/47454/#comment198007> Seems to be a bug in existing code. Can we modify this to `toDate.after(endDate) || toDate.equals(endDate)`, so that end times become exclusive. - Rajat Khandelwal On May 17, 2016, 7:05 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47454/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 7:05 p.m.) > > > Review request for lens. > > > Bugs: LENS-1144 > https://issues.apache.org/jira/browse/LENS-1144 > > > Repository: lens > > > Description > ------- > > Moved the start and end time validity to the place where partition check is > happening, instead of filtering storages earlier. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > c8190bc > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 46b6bb7 > lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java > e7b9403 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > b9694d7 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 9053e21 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/LensServerAPITestUtil.java > 84139a4 > > Diff: https://reviews.apache.org/r/47454/diff/ > > > Testing > ------- > > Cube tests pass > > > Thanks, > > Amareshwari Sriramadasu > >
