----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47454/#review133700 -----------------------------------------------------------
Ship it! Ship It! - Rajat Khandelwal On May 18, 2016, 12:44 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47454/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 12:44 a.m.) > > > Review request for lens. > > > Bugs: LENS-1144 > https://issues.apache.org/jira/browse/LENS-1144 > > > Repository: lens > > > Description > ------- > > Moved the start and end time validity to the place where partition check is > happening, instead of filtering storages earlier. > Filtering of storages earlier still happens if range start is after end date > or range end is before start date. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > c8190bc > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 46b6bb7 > lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java > e7b9403 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > d992967 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > b9694d7 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 9053e21 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/LensServerAPITestUtil.java > 84139a4 > > Diff: https://reviews.apache.org/r/47454/diff/ > > > Testing > ------- > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; > support was removed in 8.0 > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; > support was removed in 8.0 > Running TestSuite > Tests run: 397, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 807.733 sec > - in TestSuite > > Results : > > Tests run: 397, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Amareshwari Sriramadasu > >
