----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47450/#review133693 -----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java (line 66) <https://reviews.apache.org/r/47450/#comment198283> Can we change the name to TestDuplicateQuerySubmissions or TestDuplicateQueries lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java (line 124) <https://reviews.apache.org/r/47450/#comment198285> lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java (line 138) <https://reviews.apache.org/r/47450/#comment198286> Also do we need separate methods for createTable, loadData and dropTable? These methods are just calling another method. Should we call createTable() and loadData() form setup to keep it consistent (we are dropping table in teatDown()). lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java (line 160) <https://reviews.apache.org/r/47450/#comment198284> is @Test annotation required? Please check - Puneet Gupta On May 17, 2016, 11:53 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47450/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 11:53 a.m.) > > > Review request for lens. > > > Bugs: LENS-1143 > https://issues.apache.org/jira/browse/LENS-1143 > > > Repository: lens > > > Description > ------- > > Fixing test cases: > default value of lens.server.duplicate.query.allowed is false in the > lens-site, which should be true in test cases. > This patch fixes this and provides a separate test case for duplicate queries. > > > Diffs > ----- > > lens-ml-lib/src/test/resources/lens-site.xml 9be7850 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 692a0a0 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java > PRE-CREATION > lens-server/src/test/resources/lens-site.xml e6e5d2c > > Diff: https://reviews.apache.org/r/47450/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
