----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47450/#review134718 -----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/TestServerMode.java <https://reviews.apache.org/r/47450/#comment199607> This part should already be commited LENS-1010. Can u merge the latest and give a patch again lens-server/src/test/java/org/apache/lens/server/query/TestDuplicateQueries.java (line 134) <https://reviews.apache.org/r/47450/#comment199608> This can be true. Then a dummy query will not be required. lens-server/src/test/java/org/apache/lens/server/query/TestDuplicateQueries.java (lines 144 - 150) <https://reviews.apache.org/r/47450/#comment199609> Should we directly use queryService.executeAsync() like we are using for opening session ? OR .. we can use the util class RestAPITestUtil.execute() if rest calls are really required. we can follow the same elsewwhere. - Puneet Gupta On May 24, 2016, 9:56 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47450/ > ----------------------------------------------------------- > > (Updated May 24, 2016, 9:56 a.m.) > > > Review request for lens. > > > Bugs: LENS-1143 > https://issues.apache.org/jira/browse/LENS-1143 > > > Repository: lens > > > Description > ------- > > Fixing test cases: > default value of lens.server.duplicate.query.allowed is false in the > lens-site, which should be true in test cases. > This patch fixes this and provides a separate test case for duplicate queries. > > > Diffs > ----- > > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java > fce6e5f > > lens-server/src/test/java/org/apache/lens/server/query/TestDuplicateQueries.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java > 0828403 > > Diff: https://reviews.apache.org/r/47450/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
