> On May 25, 2016, 11:23 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/query/constraint/DefaultQueryLaunchingConstraintsChecker.java, > > line 58 > > <https://reviews.apache.org/r/47776/diff/1/?file=1392426#file1392426line58> > > > > Does queryConstraint classes have toString ? Or are we actually > > printing class name here?
The intention was to print class name. That should be good enough. If more details are needed, the constraint classes can implement `toString` without any changes here. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47776/#review134704 ----------------------------------------------------------- On May 24, 2016, 7:32 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47776/ > ----------------------------------------------------------- > > (Updated May 24, 2016, 7:32 p.m.) > > > Review request for lens. > > > Bugs: LENS-1151 > https://issues.apache.org/jira/browse/LENS-1151 > > > Repository: lens > > > Description > ------- > > Current logs don't give much info and for debugging why a query took so much > time in queue would be helpful to understand whether or not the wait time of > a query is valid. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b > > lens-server/src/main/java/org/apache/lens/server/query/constraint/DefaultQueryLaunchingConstraintsChecker.java > 2decf42ec9f06ef9019af24bf64c749edd484cff > > Diff: https://reviews.apache.org/r/47776/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
