> On May 25, 2016, 5:54 a.m., Puneet Gupta wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/WeightCostSelector.java, > > lines 46-48 > > <https://reviews.apache.org/r/47777/diff/1/?file=1392428#file1392428line46> > > > > Better to check explicitly is debug logs are enabled before going into > > this loop . In most cases this loop can be skipped. > > Anshul Gupta wrote: > Added check for whether debug logs are enabled. > Added driver ratio in the debug logs. > > Puneet Gupta wrote: > Did not find the check in latest path . Please check
The earlier diff wasn't created properly. Added at Line 51 of WeightedQueryCostDriverSelector > On May 25, 2016, 5:54 a.m., Puneet Gupta wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/WeightCostSelector.java, > > line 51 > > <https://reviews.apache.org/r/47777/diff/1/?file=1392428#file1392428line51> > > > > Should we optimize in case only one driver is selected ? We can skip > > all the extra processing in this case > > Anshul Gupta wrote: > Optimized for the same. > > Puneet Gupta wrote: > Did not find it in latest patch. Added - Anshul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47777/#review134702 ----------------------------------------------------------- On May 26, 2016, 10:07 a.m., Anshul Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47777/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 10:07 a.m.) > > > Review request for lens. > > > Bugs: LENS-661 > https://issues.apache.org/jira/browse/LENS-661 > > > Repository: lens > > > Description > ------- > > Added Weighted selector > > > Diffs > ----- > > > lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java > 82672294fcbf462db1fd75f00e796d5dae9d2c22 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 85f54d1f835f86dd6122a987525853e0ffa9488c > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/WeightedQueryCostDriverSelector.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestMinCostSelector.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestWeightedCostSelector.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47777/diff/ > > > Testing > ------- > > Here's the reactor summary after running mvn clean package > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Server ........................................ SUCCESS [11:32 > min] > [INFO] Lens client ........................................ SUCCESS [01:49 > min] > [INFO] Lens CLI ........................................... SUCCESS [02:02 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 8.430 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 2.801 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 21.429 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [02:28 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 20.690 > s] > [INFO] Lens Regression .................................... SUCCESS [ 9.313 > s] > [INFO] Lens UI ............................................ SUCCESS [ 14.163 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:10 min > [INFO] Finished at: 2016-05-24T20:31:02+05:30 > [INFO] Final Memory: 103M/466M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Anshul Gupta > >
