> On May 25, 2016, 12:50 p.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/driver/cube/TestWeightedCostSelector.java, > > line 78 > > <https://reviews.apache.org/r/47777/diff/2/?file=1393439#file1393439line78> > > > > Define constants for property name and default value in > > `LensConfConstants`.
<p>Defined the constant. Default value is already being specified in the getDouble method.</p> > On May 25, 2016, 12:50 p.m., Rajat Khandelwal wrote: > > lens-cube/src/test/java/org/apache/lens/driver/cube/TestWeightedCostSelector.java, > > line 132 > > <https://reviews.apache.org/r/47777/diff/2/?file=1393439#file1393439line132> > > > > Maybe we should rename it to `lens.driver.weight`. Having both `ratio` > > and `weight` might be confusing to the end-user. For end users, they need > > to set the selector class name in `lens-site.xml` and this property in > > driver's configuration files. The combination of <WeightedSelector, > > lens.driver.weight> sounds more intuitive. renamed to lens.driver.weight > On May 25, 2016, 12:50 p.m., Rajat Khandelwal wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/WeightCostSelector.java, > > line 32 > > <https://reviews.apache.org/r/47777/diff/2/?file=1393440#file1393440line32> > > > > Rename to a more explicit name like `WeightedQueryCostDriverSelector`. renamed On May 25, 2016, 12:50 p.m., Anshul Gupta wrote: > > The reactor summary is incomplete. It doesn't cover all the modules. Updated reactor summary. - Anshul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47777/#review134760 ----------------------------------------------------------- On May 26, 2016, 10:07 a.m., Anshul Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47777/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 10:07 a.m.) > > > Review request for lens. > > > Bugs: LENS-661 > https://issues.apache.org/jira/browse/LENS-661 > > > Repository: lens > > > Description > ------- > > Added Weighted selector > > > Diffs > ----- > > > lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java > 82672294fcbf462db1fd75f00e796d5dae9d2c22 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 85f54d1f835f86dd6122a987525853e0ffa9488c > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/WeightedQueryCostDriverSelector.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestMinCostSelector.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestWeightedCostSelector.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47777/diff/ > > > Testing > ------- > > Here's the reactor summary after running mvn clean package > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Server ........................................ SUCCESS [11:32 > min] > [INFO] Lens client ........................................ SUCCESS [01:49 > min] > [INFO] Lens CLI ........................................... SUCCESS [02:02 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 8.430 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 2.801 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 21.429 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [02:28 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 20.690 > s] > [INFO] Lens Regression .................................... SUCCESS [ 9.313 > s] > [INFO] Lens UI ............................................ SUCCESS [ 14.163 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:10 min > [INFO] Finished at: 2016-05-24T20:31:02+05:30 > [INFO] Final Memory: 103M/466M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Anshul Gupta > >
