----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47777/#review135473 -----------------------------------------------------------
lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestWeightedCostSelector.java (line 147) <https://reviews.apache.org/r/47777/#comment200483> No need to pass the first argument as that's already a class level variable. lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestWeightedCostSelector.java (line 150) <https://reviews.apache.org/r/47777/#comment200484> No need for numbering test cases. Each test case is independent and complete in itself. There is no ordering between test cases as to which one is first and which one is second. lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestWeightedCostSelector.java (line 234) <https://reviews.apache.org/r/47777/#comment200487> Name this test case too. - Rajat Khandelwal On May 30, 2016, 1:26 p.m., Anshul Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47777/ > ----------------------------------------------------------- > > (Updated May 30, 2016, 1:26 p.m.) > > > Review request for lens. > > > Bugs: LENS-661 > https://issues.apache.org/jira/browse/LENS-661 > > > Repository: lens > > > Description > ------- > > Added Weighted selector > > > Diffs > ----- > > > lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java > 82672294fcbf462db1fd75f00e796d5dae9d2c22 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 85f54d1f835f86dd6122a987525853e0ffa9488c > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/WeightedQueryCostDriverSelector.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestMinCostSelector.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestWeightedCostSelector.java > PRE-CREATION > src/site/apt/admin/jdbcdriver-config.apt > 8a2666fd17b439fcd8dc9d299ce4c3655eeb87e8 > > Diff: https://reviews.apache.org/r/47777/diff/ > > > Testing > ------- > > Here's the reactor summary after running mvn clean package > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Server ........................................ SUCCESS [11:32 > min] > [INFO] Lens client ........................................ SUCCESS [01:49 > min] > [INFO] Lens CLI ........................................... SUCCESS [02:02 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 8.430 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 2.801 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 21.429 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [02:28 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 20.690 > s] > [INFO] Lens Regression .................................... SUCCESS [ 9.313 > s] > [INFO] Lens UI ............................................ SUCCESS [ 14.163 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:10 min > [INFO] Finished at: 2016-05-24T20:31:02+05:30 > [INFO] Final Memory: 103M/466M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Anshul Gupta > >
