-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/
-----------------------------------------------------------
(Updated June 28, 2016, 10:49 a.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Changes
-------
Revert LENS-853 and close lens client in tests using try-with-resource
Bugs: lens-991
https://issues.apache.org/jira/browse/lens-991
Repository: lens
Description
-------
Shutdown hook was getting called for each lens **command bean** whenver we do
ctrl+c on cli.
Diffs (updated)
-----
checkstyle/src/main/resources/checkstyle.xml 0a37d01
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java
9eb73b3
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
d1ec94e
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java f53ed6b
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java
705aace
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java
80dd0d1
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 4d8341a
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ea464d5
Diff: https://reviews.apache.org/r/45099/diff/
Testing
-------
**Before applying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException:
Unable to close lens connection with params
LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi',
user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
at
org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
at
org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
at
org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
**After aplying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
Thanks,
Raju Bairishetti
