-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45099/
-----------------------------------------------------------
(Updated June 28, 2016, 10:56 a.m.)
Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
Bugs: lens-991
https://issues.apache.org/jira/browse/lens-991
Repository: lens
Description
-------
Shutdown hook was getting called for each lens **command bean** whenver we do
ctrl+c on cli.
Diffs
-----
checkstyle/src/main/resources/checkstyle.xml 0a37d01
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java
9eb73b3
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
d1ec94e
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java f53ed6b
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java
705aace
lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java
80dd0d1
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 4d8341a
lens-client/src/test/java/org/apache/lens/client/TestLensClient.java ea464d5
Diff: https://reviews.apache.org/r/45099/diff/
Testing (updated)
-------
**Before applying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>Exception in thread "Thread-3" java.lang.IllegalStateException:
Unable to close lens connection with params
LensConnectionParams{dbName='default', baseUrl='http://0.0.0.0:9999/lensapi',
user=anonymous, lensConfs={}, lensVars={}, sessionVars={}}
at org.apache.lens.client.LensConnection.close(LensConnection.java:206)
at
org.apache.lens.client.LensClient.closeConnection(LensClient.java:326)
at
org.apache.lens.cli.commands.BaseLensCommand.closeClientConnection(BaseLensCommand.java:92)
at
org.apache.lens.cli.commands.BaseLensCommand$2.run(BaseLensCommand.java:81)
LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
**After aplying patch:**
lens-shell>show cubes
No cube found
lens-shell>show params
...
lens-shell>LZDLocalAdmins-MacBook-Pro-2:client rajubairishetti$
All tests are passing except TestUnionQueries from lens-cube. Jira is already
present for that.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.444s]
[INFO] Lens .............................................. SUCCESS [2.541s]
[INFO] Lens API .......................................... SUCCESS [19.498s]
[INFO] Lens API for server and extensions ................ SUCCESS [15.130s]
[INFO] Lens Cube ......................................... SUCCESS [8:07.699s]
[INFO] Lens DB storage ................................... SUCCESS [14.925s]
[INFO] Lens Query Library ................................ SUCCESS [12.489s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:13.761s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [28.063s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [12.738s]
[INFO] Lens Server ....................................... SUCCESS [15:45.092s]
[INFO] Lens client ....................................... SUCCESS [31.307s]
[INFO] Lens CLI .......................................... SUCCESS [40.512s]
[INFO] Lens Examples ..................................... SUCCESS [8.947s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.851s]
[INFO] Lens Distribution ................................. SUCCESS [8.523s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:10.915s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.558s]
[INFO] Lens Regression ................................... SUCCESS [10.022s]
[INFO] Lens UI ........................................... SUCCESS [0.344s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:46.885s
[INFO] Finished at: Mon Feb 29 08:59:11 SGT 2016
[INFO] Final Memory: 184M/1244M
[INFO] ------------------------------------------------------------------------
Thanks,
Raju Bairishetti
