----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49770/#review141596 -----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java (line 74) <https://reviews.apache.org/r/49770/#comment206935> comments need to be updated too lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java (line 186) <https://reviews.apache.org/r/49770/#comment206936> Should we return Info instead ? That can be used to get more details about the instances otherwise the user has to make more calls to get Info about each handle. - Puneet Gupta On July 11, 2016, 3:39 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49770/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 3:39 p.m.) > > > Review request for lens. > > > Bugs: LENS-128 > https://issues.apache.org/jira/browse/LENS-128 > > > Repository: lens > > > Description > ------- > > Implementaion of core scheduler: > TODO: > 1. Test cases. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java > 7d06689 > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java > 8158576 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > 33ec9d9 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > bd9b1ab > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java > 3ca7eb9 > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java > d0af876 > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 74bc0be > > lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java > 39c4d98 > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java > bf99fde > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > 3952671 > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java > a4cdd83 > > lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java > 31783ad > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > e77c7fa > > lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java > d76a586 > > lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerServiceTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/49770/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
