> On July 18, 2016, 10:54 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java, > > line 148 > > <https://reviews.apache.org/r/49770/diff/4/?file=1444755#file1444755line148> > > > > Shall we move the `nextTransition` method to the enum instead of the > > `State` object? That way, creating such new instances can be avoided.
That's why we wanted to store JobInstanceState Object rather than JobInstanceStatus enum in the InstanceInfo. But that is not possible becuase we have to move all of the classes to lens-api which is not good. > On July 18, 2016, 10:54 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java, > > lines 140-144 > > <https://reviews.apache.org/r/49770/diff/4/?file=1444754#file1444754line140> > > > > Mismatch. One place uses `state`, another uses `status`. There is lots of confusion because of state and status - Lavkesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49770/#review142352 ----------------------------------------------------------- On July 15, 2016, 9:12 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49770/ > ----------------------------------------------------------- > > (Updated July 15, 2016, 9:12 a.m.) > > > Review request for lens. > > > Bugs: LENS-128 > https://issues.apache.org/jira/browse/LENS-128 > > > Repository: lens > > > Description > ------- > > Implementaion of core scheduler: > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java > 7d06689 > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java > 8158576 > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > 33ec9d9 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > bd9b1ab > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java > 3ca7eb9 > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java > d0af876 > > lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobInstanceState.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobState.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 74bc0be > lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 > > lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java > 39c4d98 > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java > bf99fde > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > 3952671 > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java > a4cdd83 > > lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java > 95057e4 > > lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java > d21cd05 > > lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java > 31783ad > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > e77c7fa > > lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java > d76a586 > > lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java > 06883ae > > Diff: https://reviews.apache.org/r/49770/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
