----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review144070 -----------------------------------------------------------
We already have registerForCompletionNotification in driver api. Should we use that updates from JDBC and other drivers - instead of adding another StatusUpdateMethod and etc. ? - Amareshwari Sriramadasu On July 29, 2016, 8:23 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50600/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 8:23 a.m.) > > > Review request for lens. > > > Bugs: LENS-1243 > https://issues.apache.org/jira/browse/LENS-1243 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 8047302d880a99fc04dac82b58a67d968e242dd1 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 491aa6976d6e73ddfb45494823cae7d6a3429887 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java > f1d844a1987d7f7990b2e10f03d2e3af8e0294e0 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java > 2374c1e4b2737a0d1ea7123232800413baa9a560 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > 95ea3608e612aff44ec78eee003c05ccd3068ffb > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > e160f58bfb45cffb05b9f6be19db3bc7605dde57 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 2641b606faa20943a5f3b9de9b729380a35e8c25 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > fddd3e490ade5eb4a6dce74ba17269c052390367 > > Diff: https://reviews.apache.org/r/50600/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
