> On July 29, 2016, 4:08 p.m., Puneet Gupta wrote: > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java, > > lines 337-340 > > <https://reviews.apache.org/r/50600/diff/1/?file=1457703#file1457703line337> > > > > Do we need to syncronize this on query context to make sure that cancel > > call and this code is thread safe.
If cancel and completion are having a race condition, then I believe either of the statuses would be satisfactory to the end-user. So not adding locks here. Besides, driver state update designed as a forward moving state machine. SUCCESSFUL can move to CANCELED, but not the other way around. This check is just a soft check around final status being `CANCELED+resultSetAvailable`. > On July 29, 2016, 4:08 p.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 797 > > <https://reviews.apache.org/r/50600/diff/1/?file=1457712#file1457712line797> > > > > We can miss adding this listerer if the query execution finishes very > > fast. Now listener is added before launching on driver. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review144069 ----------------------------------------------------------- On Aug. 4, 2016, 6:30 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50600/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 6:30 p.m.) > > > Review request for lens. > > > Bugs: LENS-1243 > https://issues.apache.org/jira/browse/LENS-1243 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java > 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 1326611d01e7a9b4f58877435f36b1391ca178b2 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > 6dff173e26993e40e3cb82622be8173359f92592 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > bebb9ae9a4d694f224f0ec907df166880e0cf5b8 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > e7636d2e631cf86021af398ee31300441a335096 > lens-driver-jdbc/src/test/resources/hive-site.xml > b497ca19b14811ecb4474b7f9bf6dec2bdf0b036 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java > f1d844a1987d7f7990b2e10f03d2e3af8e0294e0 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java > 2374c1e4b2737a0d1ea7123232800413baa9a560 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > 95ea3608e612aff44ec78eee003c05ccd3068ffb > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java > 3713b5156e2cfc20528d9b3b9a6f9b117daeb284 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 2641b606faa20943a5f3b9de9b729380a35e8c25 > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 59f85691d08e7deb5e3b5892b3ffc729265874d8 > lens-server/src/main/java/org/apache/lens/server/LensServerConf.java > e977ebd82118307bdbfd20be762a523337da4788 > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > 47159b568e9eff2f39ede9839f278441f0305d1f > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 84dcecda0970d2756a943522a5876117daa71409 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 9f40a014bebdfc6f0ff7ea3d7a21baacc890018d > lens-server/src/test/resources/hive-site.xml > 94c5012821330e1a78aad2a7fdfca0cc1d0fade2 > > Diff: https://reviews.apache.org/r/50600/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
