> On Aug. 10, 2016, 12:51 p.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java, > > line 56 > > <https://reviews.apache.org/r/50600/diff/9/?file=1468820#file1468820line56> > > > > no cancel here?
I don't think we need that here. This is implementing Completion Listener using Status Update listener. We only need to handle success and failure scenarios. Am I missing something? > On Aug. 10, 2016, 12:51 p.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > line 572 > > <https://reviews.apache.org/r/50600/diff/9/?file=1468823#file1468823line572> > > > > Shouldnt query context update its own status also once driver status is > > updated? > > > > When does QueryContext's status get updated in this flow? QueryService adds an Async status updater as an observer of this. So this call then notifies all the observers, including the async status updater, which then updates QueryContext's status. > On Aug. 10, 2016, 12:51 p.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > line 580 > > <https://reviews.apache.org/r/50600/diff/9/?file=1468823#file1468823line580> > > > > Who are the callers of this? why is the argument null? Most of the places, the status message is just "Query is successful/failed/canceled/...". `null` here means that status message will be derived based on the status enum value. > On Aug. 10, 2016, 12:51 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java, > > line 1047 > > <https://reviews.apache.org/r/50600/diff/9/?file=1468827#file1468827line1047> > > > > why is this change done? Not sure why we're not seeing this in master, but I was seeing an error. The flow is the following: 1. create dimension 2. create dimtable 1. create 2. get dimtable 3. get latest partition -> time dim is null, so error. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50600/#review145315 ----------------------------------------------------------- On Aug. 9, 2016, 6:34 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50600/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2016, 6:34 p.m.) > > > Review request for lens. > > > Bugs: LENS-1243 > https://issues.apache.org/jira/browse/LENS-1243 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-driver-es/src/main/java/org/apache/lens/driver/es/ESDriver.java > 8a4f4105ad6ffc75445e5e10a51f6fbd4f5f1d3f > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 1326611d01e7a9b4f58877435f36b1391ca178b2 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > 6dff173e26993e40e3cb82622be8173359f92592 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > bebb9ae9a4d694f224f0ec907df166880e0cf5b8 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > 12fa6f0328242b1bd06ff0397b2f2a3a9dec010d > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > e7636d2e631cf86021af398ee31300441a335096 > lens-driver-jdbc/src/test/resources/hive-site.xml > b497ca19b14811ecb4474b7f9bf6dec2bdf0b036 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java > f1d844a1987d7f7990b2e10f03d2e3af8e0294e0 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java > 2374c1e4b2737a0d1ea7123232800413baa9a560 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > 95ea3608e612aff44ec78eee003c05ccd3068ffb > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryCompletionListener.java > 3713b5156e2cfc20528d9b3b9a6f9b117daeb284 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/QueryDriverStatusUpdateListener.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/StatusUpdateMethod.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 2641b606faa20943a5f3b9de9b729380a35e8c25 > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 59f85691d08e7deb5e3b5892b3ffc729265874d8 > lens-server/src/main/java/org/apache/lens/server/LensServerConf.java > e977ebd82118307bdbfd20be762a523337da4788 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 1752414e89c550c31645f2a2fd686f5b06686a93 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > be1326f62e47c72514039fc6525eeea12ae28456 > lens-server/src/test/resources/hive-site.xml > 94c5012821330e1a78aad2a7fdfca0cc1d0fade2 > > Diff: https://reviews.apache.org/r/50600/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
