> On Aug. 3, 2016, 7:41 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java, line 938
> > <https://reviews.apache.org/r/50740/diff/1/?file=1461103#file1461103line938>
> >
> >     1. Nochange => NoChange

Using enum as mentioned in earlier comment, this would be the default mode


- Rajitha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50740/#review144589
-----------------------------------------------------------


On Aug. 3, 2016, 7:28 a.m., Rajitha R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50740/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2016, 7:28 a.m.)
> 
> 
> Review request for lens and Amareshwari Sriramadasu.
> 
> 
> Bugs: LENS-1224
>     https://issues.apache.org/jira/browse/LENS-1224
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Changes done include : 
> 1. Druid sql rewriter in Jdbc driver
> 2. New Timerangerewriter for Druid
> 3. HQLParser toString modified
> 
> 
> Diffs
> -----
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenOnlyTimeRangeWriter.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 68cdcef 
>   
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java
>  PRE-CREATION 
>   
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java
>  PRE-CREATION 
>   lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50740/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Reply via email to