----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50740/#review147117 -----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java (lines 98 - 99) <https://reviews.apache.org/r/50740/#comment214214> Default constructor need not be explicitly defined. lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java (lines 102 - 111) <https://reviews.apache.org/r/50740/#comment214215> Duplication from ColumnarSQLRewriter. This code has been refactored to single line: regexReplaceMap = CommonUtils.parseMapFromString(conf.get(JDBCDriverConfConstants.REGEX_REPLACEMENT_VALUES)); lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java (lines 171 - 185) <https://reviews.apache.org/r/50740/#comment214216> Can we avoid code duplication from ColumnarSQLRewriter? - Rajat Khandelwal On Aug. 25, 2016, 5:09 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50740/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2016, 5:09 p.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-1224 > https://issues.apache.org/jira/browse/LENS-1224 > > > Repository: lens > > > Description > ------- > > Changes done include : > 1. Druid sql rewriter in Jdbc driver > 2. New Timerangerewriter for Druid > 3. HQLParser toString modified > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java > a5b26c4 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > 49ed5ef > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 68cdcef > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java > eeba861 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java > 748f92f > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java > PRE-CREATION > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestDruidSQLRewriter.java > PRE-CREATION > lens-driver-jdbc/src/test/resources/drivers/jdbc/druid/jdbcdriver-site.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/50740/diff/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
