-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51494/#review147284
-----------------------------------------------------------




lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 
(line 64)
<https://reviews.apache.org/r/51494/#comment214392>

    let's reduce access level. default is public.



lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 
(lines 263 - 265)
<https://reviews.apache.org/r/51494/#comment214391>

    synchronization is not required if we don't want to wait. Should we 
optimize for this?



lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 
(lines 263 - 265)
<https://reviews.apache.org/r/51494/#comment214393>

    Shall we expose this template as a service level method? `notifySync` or 
something? This would ensure that Event Service interface itself has two types 
of event notification mechanisms. asynchronous and synchronous



lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 
(line 558)
<https://reviews.apache.org/r/51494/#comment214394>

    wait with timeout and fail. We don't want tests to get stuck.



lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 
(line 580)
<https://reviews.apache.org/r/51494/#comment214395>

    Let's do something here so that we can assert event was indeed processed 
before `wait` returned in the test case.


- Rajat Khandelwal


On Aug. 29, 2016, 8:22 p.m., Lavkesh Lahngir wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51494/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2016, 8:22 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1298
>     https://issues.apache.org/jira/browse/LENS-1298
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> When a thread notifies event service to process any event, it should have a 
> way to wait for it to be finished.
> 
> Also Alarmservice has an option to wait after notifying evenservice.
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java 
> 369885dea34f839561a49df7511460535f20e0ed 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java 
> 64873230e8f222983f5ed5a16e88e54b8885a75e 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  323e053727f65891ceefbc9dab09b9cdbe594e84 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 
> 94011d2c82d48344e5de62efae5acb19cb17adfc 
> 
> Diff: https://reviews.apache.org/r/51494/diff/
> 
> 
> Testing
> -------
> 
> 1. Added test in Eventservice test
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Reply via email to