----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51494/#review147628 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java (line 195) <https://reviews.apache.org/r/51494/#comment214834> Instead should we do new EventHandler().run() here ? No wait and notify will be required. - Amareshwari Sriramadasu On Sept. 1, 2016, 9:26 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51494/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2016, 9:26 a.m.) > > > Review request for lens. > > > Bugs: LENS-1298 > https://issues.apache.org/jira/browse/LENS-1298 > > > Repository: lens > > > Description > ------- > > When a thread notifies event service to process any event, it should have a > way to wait for it to be finished. > > Also Alarmservice has an option to wait after notifying evenservice. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/events/LensEventService.java > 4536a18 > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java > 0f2dabe > lens-server/src/main/java/org/apache/lens/server/EventServiceImpl.java > 369885d > > lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java > 6487323 > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > 323e053 > > lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java > 94011d2 > > Diff: https://reviews.apache.org/r/51494/diff/ > > > Testing > ------- > > 1. Added test in Eventservice test > > > Thanks, > > Lavkesh Lahngir > >
