-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/#review149639
-----------------------------------------------------------




lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
 (line 62)
<https://reviews.apache.org/r/52040/#comment217313>

    Do we need ON_CONDITIONS_NOT_MET to be separate? I see on_creation it is 
waiting and on conditions_met it is Launched. I dont see any need for launching 
-> waiting.


- Amareshwari Sriramadasu


On Sept. 19, 2016, 3:14 p.m., Lavkesh Lahngir wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52040/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 3:14 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1327
>     https://issues.apache.org/jira/browse/LENS-1327
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> A instance goes to waiting state when there is some data missing. They are 
> retried after some time.
> 
> 
> Diffs
> -----
> 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
>  4f3409c21748b2ae026bdeba881dcc5a988a2d3c 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
>  3d2605ea67c99bdba9e56140e0e13c9685a19c7a 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> b924167fb819b3baae6be14efbb085fe72f99f54 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  1db8136c4e352d7dc03d7614511e89c6209ae151 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  969d7403ddc0cb2a8bfa59ffde64ea249714a08e 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  16a6c78ba5b36e3a164646fec6c2aca9f032d03e 
> 
> Diff: https://reviews.apache.org/r/52040/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Reply via email to