> On Sept. 20, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java,
> >  line 62
> > <https://reviews.apache.org/r/52040/diff/1/?file=1502622#file1502622line62>
> >
> >     Do we need ON_CONDITIONS_NOT_MET to be separate? I see on_creation it 
> > is waiting and on conditions_met it is Launched. I dont see any need for 
> > launching -> waiting.

The launching status will be set when we first create the an instanceRun. The 
schedule event handler will call estimate() method and set the method to 
waiting if some partitions are missing. 
A thread will be looking for all the instances which are in waiting state, and 
set the state to launching before notifying the event service with schedule 
event. 

I guess the definition has been changed a little bit.


- Lavkesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52040/#review149639
-----------------------------------------------------------


On Sept. 19, 2016, 3:14 p.m., Lavkesh Lahngir wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52040/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 3:14 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1327
>     https://issues.apache.org/jira/browse/LENS-1327
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> A instance goes to waiting state when there is some data missing. They are 
> retried after some time.
> 
> 
> Diffs
> -----
> 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceEvent.java
>  4f3409c21748b2ae026bdeba881dcc5a988a2d3c 
>   
> lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java
>  3d2605ea67c99bdba9e56140e0e13c9685a19c7a 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java 
> b924167fb819b3baae6be14efbb085fe72f99f54 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java
>  1db8136c4e352d7dc03d7614511e89c6209ae151 
>   
> lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java
>  969d7403ddc0cb2a8bfa59ffde64ea249714a08e 
>   
> lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java
>  16a6c78ba5b36e3a164646fec6c2aca9f032d03e 
> 
> Diff: https://reviews.apache.org/r/52040/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Reply via email to