-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52088/#review149955
-----------------------------------------------------------




lens-server-api/src/main/java/org/apache/lens/server/api/common/SingleRetryHandler.java
 (line 22)
<https://reviews.apache.org/r/52088/#comment217744>

    Will SingleRetryHandler have delay for the next try?



lens-server-api/src/main/java/org/apache/lens/server/api/query/FailedAttempt.java
 (line 35)
<https://reviews.apache.org/r/52088/#comment217745>

    Should we have errorcode as well here ?



lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 (lines 210 - 216)
<https://reviews.apache.org/r/52088/#comment217746>

    All these should be defined as transient? Or there is recovery upon 
restarts?


- Amareshwari Sriramadasu


On Sept. 20, 2016, 6:26 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52088/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 6:26 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-743
>     https://issues.apache.org/jira/browse/LENS-743
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> There have to be retries for query failures for transient errors like network 
> errors (Hive server not reachable/ Metastore not reachable/ DB not 
> reachable). Retries should be available for each phase - submission, 
> execution, updating status, fetching results and formatting.
> 
> Right now, any such failure results in marking query as failed.
> 
> 
> Diffs
> -----
> 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  8f1983ee10e9e4a429dc1c8ceb5d4a65bab975c1 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/common/BackOffRetryHandler.java
>  17bfba02244bca7141268ed12e4a41400e2bec82 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/common/FibonacciExponentialBackOffRetryHandler.java
>  e7fb8ce0194803317aaa0e1c5f4e3e0fb6bbca8c 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/common/NoRetryHandler.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/common/SingleRetryHandler.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
>  03079e2dc353fa028f3c5d5a03a8ae2dbf728004 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java
>  033f6777b4be7a1b6d6cdc350e42a94ade1acbca 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
>  e472de0a452ffbbcb217503c260aa26fe7f6ed99 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java
>  5ff59bd0da713651a7cc5261dbd18cd88e91fc76 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FailedAttempt.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
>  b58fcf964cedb8dc302099ae9c806b06acafa2d3 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  b584c6a6d414a6f0dac509e67c8944dbd2373325 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/collect/ChainedComparator.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/retry/DefaultQueryRetryPolicyDecider.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/retry/QueryRetryPolicyDecider.java
>  PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 
> 8261d8aa19eb26e0336846d32c5bcd2162ddcb14 
>   lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 
> 997b5a80ab1f9516ad6aaeb431f08a61f386180a 
>   
> lens-server/src/main/java/org/apache/lens/server/query/MoreRetriesFirstComparator.java
>  PRE-CREATION 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  dafe93dde2ec8a040b855261f00723be6cd7b26e 
>   
> lens-server/src/main/java/org/apache/lens/server/query/constraint/DefaultQueryLaunchingConstraintsChecker.java
>  48291b94d35dfcf3dde6b3667b2aae28d81f9366 
>   
> lens-server/src/main/java/org/apache/lens/server/query/constraint/RetryPolicyToConstraingAdapter.java
>  PRE-CREATION 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 
> e620dc561774b396b6a498fb5b2e0f4001aaa46f 
> 
> Diff: https://reviews.apache.org/r/52088/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Reply via email to