-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52088/
-----------------------------------------------------------

(Updated Sept. 26, 2016, 8:29 p.m.)


Review request for lens.


Bugs: LENS-743
    https://issues.apache.org/jira/browse/LENS-743


Repository: lens


Description
-------

There have to be retries for query failures for transient errors like network 
errors (Hive server not reachable/ Metastore not reachable/ DB not reachable). 
Retries should be available for each phase - submission, execution, updating 
status, fetching results and formatting.

Right now, any such failure results in marking query as failed.


Diffs (updated)
-----

  contrib/clients/python/pom.xml a849038ba4c6b52fc898e3a7ae41c604e9452de1 
  lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java 
daedbf9ea387cbde3ef39363c2beef3f96725223 
  lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
84d9933da506e3f1bff2d3e0ea403ed1edf0fe35 
  
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
8cf617b7181b9a305ea2c68f68c610f823ee75d7 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/BackOffRetryHandler.java
 17bfba02244bca7141268ed12e4a41400e2bec82 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/FibonacciExponentialBackOffRetryHandler.java
 e7fb8ce0194803317aaa0e1c5f4e3e0fb6bbca8c 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/NoRetryHandler.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/common/SingleRetryHandler.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 03079e2dc353fa028f3c5d5a03a8ae2dbf728004 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java
 033f6777b4be7a1b6d6cdc350e42a94ade1acbca 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java 
e472de0a452ffbbcb217503c260aa26fe7f6ed99 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java
 5ff59bd0da713651a7cc5261dbd18cd88e91fc76 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/FailedAttempt.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java
 b58fcf964cedb8dc302099ae9c806b06acafa2d3 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 b584c6a6d414a6f0dac509e67c8944dbd2373325 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/comparators/ChainedComparator.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/comparators/FIFOQueryComparator.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/comparators/MoreRetriesFirstComparator.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/comparators/QueryComparator.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/comparators/QueryCostComparator.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/comparators/QueryPriorityComparator.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/retry/DefaultQueryRetryPolicyDecider.java
 PRE-CREATION 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/retry/QueryRetryPolicyDecider.java
 PRE-CREATION 
  lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 
8261d8aa19eb26e0336846d32c5bcd2162ddcb14 
  
lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java 
168b3cc8a2e32e4fddb66f480af38e77adef62c2 
  
lens-server-api/src/test/java/org/apache/lens/server/api/query/comparators/ChainedComparatorTest.java
 PRE-CREATION 
  lens-server/pom.xml 6dea9a7be5181db1ff2f0f2e4407d4208fbb5464 
  
lens-server/src/main/java/org/apache/lens/server/query/FIFOQueryComparator.java 
75c11460f7a0c2c5a52d6fec5e5f4b763643f3a4 
  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java 
0aada406963f7b421e8b9726a72abcd85c63ddd4 
  lens-server/src/main/java/org/apache/lens/server/query/QueryComparator.java 
67dda6bf8a74dc4a21b7f4148e5e3af9a51721d0 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryCostComparator.java 
2702581fc88a560dbb420ec3a7de1cf442542bd7 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 0bb106ed77306094710c126fc652d5c56a908d85 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryPriorityComparator.java
 2c6d904a5fd35d39b5339275013386ae7852bb73 
  
lens-server/src/main/java/org/apache/lens/server/query/constraint/DefaultQueryLaunchingConstraintsChecker.java
 48291b94d35dfcf3dde6b3667b2aae28d81f9366 
  
lens-server/src/main/java/org/apache/lens/server/query/constraint/RetryPolicyToConstraingAdapter.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/query/QueryContextComparatorTest.java
 46adb7b9b4e53c6f8182d13c33ebf76647c37a27 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 
e620dc561774b396b6a498fb5b2e0f4001aaa46f 
  
lens-server/src/test/java/org/apache/lens/server/query/TestQueryNotifictaionResource.java
 3a3f2f150505e43a9f8c3f9f0ec9d7b431f1c0d0 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
f755508529f6745caadd8eee0f63e81e1f14ed75 
  
lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java
 8b72c81554f06cf2115364fa66062572cd5aa957 
  
lens-server/src/test/java/org/apache/lens/server/query/retry/MockDriverForRetries.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/query/retry/QueryRetryTest.java
 PRE-CREATION 
  
lens-server/src/test/java/org/apache/lens/server/query/retry/TestServerRetryPolicyDecider.java
 PRE-CREATION 
  
lens-server/src/test/resources/drivers/mock/single_failure/failing-query-driver-site.xml
 PRE-CREATION 
  lens-server/src/test/resources/drivers/retry/double_failure/driver-site.xml 
PRE-CREATION 
  lens-server/src/test/resources/drivers/retry/single_failure/driver-site.xml 
PRE-CREATION 

Diff: https://reviews.apache.org/r/52088/diff/


Testing
-------


Thanks,

Rajat Khandelwal

Reply via email to