----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52028/#review150689 -----------------------------------------------------------
Fix it, then Ship it! Ship It! lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java (line 84) <https://reviews.apache.org/r/52028/#comment218727> Can we confirm that before this patch createFinishedQueriesTable() was not creating a table for a non in-memory database since there is no explicit commit statement and auto commit was turned off ? Test cases seem to pass, but then we use in-memory dbs for test cases. - Puneet Gupta On Sept. 19, 2016, 11:35 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52028/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2016, 11:35 a.m.) > > > Review request for lens. > > > Bugs: LENS-1308 > https://issues.apache.org/jira/browse/LENS-1308 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > 2ec938e951522b3026f6485ff900268d6e0039cd > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > 90226d121b5a1ca50e3fcb786437a9198d97a692 > > Diff: https://reviews.apache.org/r/52028/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
