> On Sept. 28, 2016, 12:26 p.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java, > > line 84 > > <https://reviews.apache.org/r/52028/diff/1/?file=1502552#file1502552line84> > > > > Can we confirm that before this patch createFinishedQueriesTable() was > > not creating a table for a non in-memory database since there is no > > explicit commit statement and auto commit was turned off ? > > > > Test cases seem to pass, but then we use in-memory dbs for test cases.
On mysql it doesn't work anyway. Our table schema is using things like `varchar(100000)`, mysql recommends it should be changed to `text`. I can confirm that it's at least trying to create the table. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52028/#review150689 ----------------------------------------------------------- On Oct. 3, 2016, 3:40 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52028/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2016, 3:40 p.m.) > > > Review request for lens. > > > Bugs: LENS-1308 > https://issues.apache.org/jira/browse/LENS-1308 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > 0aada406963f7b421e8b9726a72abcd85c63ddd4 > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > 90226d121b5a1ca50e3fcb786437a9198d97a692 > > Diff: https://reviews.apache.org/r/52028/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
