----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/#review162925 -----------------------------------------------------------
Please include unit tests lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 191) <https://reviews.apache.org/r/55712/#comment234320> Seems updatePeriod can be null here. looking at the following check says so. lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 343) <https://reviews.apache.org/r/55712/#comment234321> If the method is returning Map of UpdatePeriod to PartitionTimeLine, I think updatePeriod should not passed as param. The method should populate the timeline for all updatePeriod, if required by pulling from different tables corresponding to each updatePeriod. lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (lines 379 - 383) <https://reviews.apache.org/r/55712/#comment234322> Looking at the code, similar thing should be done for get() as well. lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 865) <https://reviews.apache.org/r/55712/#comment234323> new param needs to be updated lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java (line 245) <https://reviews.apache.org/r/55712/#comment234324> why commented? - Amareshwari Sriramadasu On Jan. 24, 2017, 2:57 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55712/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 2:57 p.m.) > > > Review request for lens. > > > Bugs: LENS-1386 > https://issues.apache.org/jira/browse/LENS-1386 > > > Repository: lens > > > Description > ------- > > A new data structure XUpdatePeriodTableDescriptor is introduced which > contains an update period and table descriptor. Now the XUpdatePeriods will > contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd f438f48 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > adb6c92 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 6c9cde2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 53cf8af > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > e21dc2a > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 8b10d1d > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 51fcb43 > > Diff: https://reviews.apache.org/r/55712/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
