> On Feb. 14, 2017, 11:53 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 384 > > <https://reviews.apache.org/r/55712/diff/7/?file=1632298#file1632298line384> > > > > If we are calling this for each updatePeriod separately even if the > > table is same for all updatePeriods, it can have huge impact on the time it > > takes to create timelines and requires huge memory to put all partitions.
I will add a condition if (!uniqueStorageTables.contains(storageTableName)) then only fetch partitions. > On Feb. 14, 2017, 11:53 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 499 > > <https://reviews.apache.org/r/55712/diff/7/?file=1632298#file1632298line499> > > > > no more required? what was it doing earlier which is not required now? The method code is merged with loadTimeLines() > On Feb. 14, 2017, 11:53 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 948 > > <https://reviews.apache.org/r/55712/diff/7/?file=1632298#file1632298line948> > > > > Seems javadoc is wrong Yeah.. correcting it. - Lavkesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/#review165474 ----------------------------------------------------------- On Feb. 13, 2017, 6:47 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55712/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2017, 6:47 p.m.) > > > Review request for lens. > > > Bugs: LENS-1386 > https://issues.apache.org/jira/browse/LENS-1386 > > > Repository: lens > > > Description > ------- > > A new data structure XUpdatePeriodTableDescriptor is introduced which > contains an update period and table descriptor. Now the XUpdatePeriods will > contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd f438f48 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > adb6c92 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 6c9cde2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 53cf8af > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > e21dc2a > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 8b10d1d > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 51fcb43 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 0e6a4a1 > > Diff: https://reviews.apache.org/r/55712/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
