----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/#review165641 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 1064) <https://reviews.apache.org/r/55712/#comment237505> We have to iterate over update periods that belong to the storageTableName only. Not all updatePeriods. lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 2491) <https://reviews.apache.org/r/55712/#comment237506> Please avoid using exceptions in normal flow. Why would getFactTable().getTablePrefix() throw exception? lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java (line 973) <https://reviews.apache.org/r/55712/#comment237507> Can you add partitions to these tables and validate partition timelines? lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 653) <https://reviews.apache.org/r/55712/#comment237508> Please avoid using exception in normal flow. lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 749) <https://reviews.apache.org/r/55712/#comment237509> Same as above, avoid exceptions in normal flow. lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java (line 1874) <https://reviews.apache.org/r/55712/#comment237511> What are these table names are for? lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java (line 1886) <https://reviews.apache.org/r/55712/#comment237512> Can you pull native tables and validate the separate tables for each update period exist? lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java (line 2003) <https://reviews.apache.org/r/55712/#comment237510> Can you drop fact and assert all storage tables are dropped? You might need to pull native tables to check the same - Amareshwari Sriramadasu On Feb. 13, 2017, 6:47 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55712/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2017, 6:47 p.m.) > > > Review request for lens. > > > Bugs: LENS-1386 > https://issues.apache.org/jira/browse/LENS-1386 > > > Repository: lens > > > Description > ------- > > A new data structure XUpdatePeriodTableDescriptor is introduced which > contains an update period and table descriptor. Now the XUpdatePeriods will > contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd f438f48 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > adb6c92 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 6c9cde2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 53cf8af > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > e21dc2a > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 8b10d1d > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 51fcb43 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 0e6a4a1 > > Diff: https://reviews.apache.org/r/55712/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
