-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59223/#review174767
-----------------------------------------------------------



Please add unit tests for all three cases mentioned in description.

- Amareshwari Sriramadasu


On May 12, 2017, 8:53 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59223/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 8:53 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1420
>     https://issues.apache.org/jira/browse/LENS-1420
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Below bugs are addressed in final rewritten query.
> 1. Expressions used in having clause are not resolved in the final rewritten 
> query incase of picked candidate is a segmentation.
> 2. Alias is not being replaced in order by clause for segmentation queries.
> 3. Query with two dim attributes referring to same join chain ending with 
> wrong alias replacement.
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> f86a84a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
> bd7134b 
> 
> 
> Diff: https://reviews.apache.org/r/59223/diff/1/
> 
> 
> Testing
> -------
> 
> lens-cube test cases are running fine.
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; 
> support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
> support was removed in 8.0
> Running TestSuite
> 
> Tests run: 440, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 493.856 sec 
> - in TestSuite
> 
> Results :
> 
> Tests run: 440, Failures: 0, Errors: 0, Skipped: 0
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 9:37.126s
> [INFO] Finished at: Fri May 12 12:44:16 IST 2017
> [INFO] Final Memory: 65M/1499M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Reply via email to