-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59223/
-----------------------------------------------------------
(Updated May 12, 2017, 11:07 a.m.)
Review request for lens.
Changes
-------
Added unit tests to validate the bug fixes.
Bugs: LENS-1420
https://issues.apache.org/jira/browse/LENS-1420
Repository: lens
Description
-------
Below bugs are addressed in final rewritten query.
1. Expressions used in having clause are not resolved in the final rewritten
query incase of picked candidate is a segmentation.
2. Alias is not being replaced in order by clause for segmentation queries.
3. Query with two dim attributes referring to same join chain ending with wrong
alias replacement.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java
f86a84a
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java
bd7134b
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeSegmentationRewriter.java
7f8662a
lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionAndJoinCandidates.java
0119f2e
lens-cube/src/test/resources/schema/cubes/base/b1c1cube.xml 6ab528a
lens-cube/src/test/resources/schema/cubes/base/b1cube.xml ef0e33d
lens-cube/src/test/resources/schema/cubes/base/b2c1cube.xml c71540b
lens-cube/src/test/resources/schema/cubes/base/b2cube.xml f0a80be
lens-cube/src/test/resources/schema/cubes/base/basecube.xml b8585ac
lens-cube/src/test/resources/schema/cubes/base/testcube.xml 2a11c88
lens-cube/src/test/resources/schema/cubes/derived/union_join_ctx_der1.xml
1308483
Diff: https://reviews.apache.org/r/59223/diff/2/
Changes: https://reviews.apache.org/r/59223/diff/1-2/
Testing
-------
lens-cube test cases are running fine.
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m;
support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m;
support was removed in 8.0
Running TestSuite
Tests run: 440, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 493.856 sec -
in TestSuite
Results :
Tests run: 440, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 9:37.126s
[INFO] Finished at: Fri May 12 12:44:16 IST 2017
[INFO] Final Memory: 65M/1499M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
