> On Aug. 29, 2017, 5:27 a.m., Amareshwari Sriramadasu wrote:
> > Can you add a testcase?

Done


> On Aug. 29, 2017, 5:27 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
> > Line 936 (original), 936 (patched)
> > <https://reviews.apache.org/r/61938/diff/1/?file=1806054#file1806054line936>
> >
> >     Line above is truncating partitions, isnt get Partitions here empty 
> > always?

No it isn't empty in case of look ahead partitions being available


- Rajitha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61938/#review184022
-----------------------------------------------------------


On Aug. 28, 2017, 11:38 a.m., Rajitha R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61938/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2017, 11:38 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Fix for time_range_in clause not resolving in rewrite
> 
> 
> Diffs
> -----
> 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> 2b1add3 
> 
> 
> Diff: https://reviews.apache.org/r/61938/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Reply via email to