> On March 21, 2018, 1:58 a.m., Ankit Kailaswar wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java > > Lines 36 (patched) > > <https://reviews.apache.org/r/66081/diff/1/?file=1976384#file1976384line36> > > > > If we try to extend RetryingThriftCLIServiceClient then it forces us to > > override all member functions since we cant access private data members of > > base class in derived class. we are doing it now anyhow but invokeInternal > > in base class refer to inner protected class "InvocationResult" if we try > > to overide invokeinternal then we are force to use "InvocationResult" in > > our implementation. since this class is inner protected class it cant be > > accessed from outside the class. This problem can be solved by extending > > InvocationResult. This require initialising base class in derived class's > > constructor causing same issue of not been able to use class outside > > package. > > Rajat Khandelwal wrote: > This can be solved by making the package of this class > `org.apache.hive.service.cli.thrift`.
Also the method `invokeInternal` and member `base` will need to be copied. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66081/#review199570 ----------------------------------------------------------- On March 21, 2018, 2:13 a.m., Ankit Kailaswar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66081/ > ----------------------------------------------------------- > > (Updated March 21, 2018, 2:13 a.m.) > > > Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and > Puneet Gupta. > > > Repository: lens > > > Description > ------- > > https://issues.apache.org/jira/browse/LENS-1506 > > This patch contains code changes to enable kerberos authentication for > 1. lens to hive > 2. lens to metastore > 3. lens to hdfs > > code changes are as follows, > 1. new http thrift client for hive driver to support sasl transport for > kerberozied hive server. > 2. cron to update KDC ticket before it expires. > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 2eb94aa7 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java > 54885f77 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > d5273be8 > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > b9fcdd8b > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 31ac358d > > > Diff: https://reviews.apache.org/r/66081/diff/2/ > > > Testing > ------- > > unit testing > > > Thanks, > > Ankit Kailaswar > >
