-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/#review200175
-----------------------------------------------------------




lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 64 (patched)
<https://reviews.apache.org/r/66081/#comment280816>

    can be removed if not required



lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
Lines 177 (patched)
<https://reviews.apache.org/r/66081/#comment280818>

    Can you explain why is the kerberos implementation skipped here?



lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
Lines 78 (patched)
<https://reviews.apache.org/r/66081/#comment280817>

    comment should be corrected


- Rajitha R


On March 20, 2018, 8:43 p.m., Ankit Kailaswar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66081/
> -----------------------------------------------------------
> 
> (Updated March 20, 2018, 8:43 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and 
> Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/LENS-1506
> 
> This patch contains code changes to enable kerberos authentication for 
> 1. lens to hive 
> 2. lens to metastore
> 3. lens to hdfs
> 
> code changes are as follows,
> 1. new http thrift client for hive driver to support sasl transport for 
> kerberozied hive server.
> 2. cron to update KDC ticket before it expires.
> 
> 
> Diffs
> -----
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 2eb94aa7 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
>  54885f77 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  d5273be8 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> b9fcdd8b 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  31ac358d 
> 
> 
> Diff: https://reviews.apache.org/r/66081/diff/2/
> 
> 
> Testing
> -------
> 
> unit testing
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Reply via email to