-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66081/#review200541
-----------------------------------------------------------




lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
Lines 130 (patched)
<https://reviews.apache.org/r/66081/#comment281277>

    can you add a comment why this is required.



lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java
Lines 148 (patched)
<https://reviews.apache.org/r/66081/#comment281274>

    Can you import SecurityUtil ?



lens-server/src/main/java/org/apache/lens/server/LensServices.java
Lines 299 (patched)
<https://reviews.apache.org/r/66081/#comment281276>

    can you move the KDC code to a separate method ?



lens-server/src/main/java/org/apache/lens/server/LensServices.java
Lines 304 (patched)
<https://reviews.apache.org/r/66081/#comment281273>

    Should we catch Exception instead in this case ?


- Puneet Gupta


On April 5, 2018, 5:41 a.m., Ankit Kailaswar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66081/
> -----------------------------------------------------------
> 
> (Updated April 5, 2018, 5:41 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and 
> Puneet Gupta.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/LENS-1506
> 
> This patch contains code changes to enable kerberos authentication for 
> 1. lens to hive 
> 2. lens to metastore
> 3. lens to hdfs
> 
> code changes are as follows,
> 1. new http thrift client for hive driver to support sasl transport for 
> kerberozied hive server.
> 2. cron to update KDC ticket before it expires.
> 
> 
> Diffs
> -----
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 2eb94aa7 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java
>  54885f77 
>   
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  d5273be8 
>   lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java 
> 9d732c1c 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> c30a2d72 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 903b19fe 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  31ac358d 
>   lens-server/src/main/resources/lensserver-default.xml 28b1db29 
>   lens-server/src/test/resources/lens-site.xml 7e5f522e 
>   tools/scripts/lens-ctl 304b4f5a 
> 
> 
> Diff: https://reviews.apache.org/r/66081/diff/7/
> 
> 
> Testing
> -------
> 
> unit testing
> 
> 
> Thanks,
> 
> Ankit Kailaswar
> 
>

Reply via email to