Amareshwari commented on a change in pull request #35: [LENS-1545]: Fixed Bug in Prepared Query. URL: https://github.com/apache/lens/pull/35#discussion_r313780258
########## File path: lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java ########## @@ -556,6 +556,8 @@ public String getPlan() { public QueryCost estimate(AbstractQueryContext qctx) throws LensException { MethodMetricsContext validateGauge = MethodMetricsFactory.createMethodGauge(qctx.getDriverConf(this), true, VALIDATE_GAUGE); + String rewrittenQuery = rewriteQuery(qctx); Review comment: Not sure why changes are done in estimate, when you are fixing bug in prepareQuery. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services