RajashekharChoukimath commented on a change in pull request #35: [LENS-1545]: 
Fixed Bug in Prepared Query.
URL: https://github.com/apache/lens/pull/35#discussion_r313801600
 
 

 ##########
 File path: 
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
 ##########
 @@ -556,6 +556,8 @@ public String getPlan() {
   public QueryCost estimate(AbstractQueryContext qctx) throws LensException {
     MethodMetricsContext validateGauge = 
MethodMetricsFactory.createMethodGauge(qctx.getDriverConf(this), true,
       VALIDATE_GAUGE);
+    String rewrittenQuery = rewriteQuery(qctx);
 
 Review comment:
   In the azure-world, we are not going to have Lens interacting with the 
actual underlying drivers. 
https://docs.google.com/document/d/1K5Q3ZQZAEGkf472DZ_zuLbHZ9ycx86YAEhqbxO0o-aA/edit#
   
   
   The cleaner way for me is to remove driverconnection which Lens is making 
for the explain part in 
   
https://github.com/apache/lens/blob/master/lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java#L728
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to