> On Dec. 3, 2014, 5:14 a.m., Suma Shivaprasad wrote: > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java, > > line 492 > > <https://reviews.apache.org/r/28630/diff/1/?file=780755#file780755line492> > > > > shudnt the same change be applied to TestHiveDriver?
In Hive server, cancel call succeedes even if the query (or Operation rather) is complete by the time we issue the cancel call. It could throw an invalid operation error in case the server has restarted in the mean time. Anyway, similar failure is unlikely in TestHiveDriver. - Jaideep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28630/#review63644 ----------------------------------------------------------- On Dec. 3, 2014, 5:10 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28630/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2014, 5:10 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Sushil Mohanty. > > > Bugs: LENS-87 > https://issues.apache.org/jira/browse/LENS-87 > > > Repository: lens > > > Description > ------- > > Test case should check if query cancel was successful and then evaluate > status accordingly. > > > Diffs > ----- > > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 30b7935 > > Diff: https://reviews.apache.org/r/28630/diff/ > > > Testing > ------- > > Modified exsiting test for cancel query. > > > Thanks, > > Jaideep dhok > >
