----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28849/#review64509 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java <https://reviews.apache.org/r/28849/#comment107251> Looks like code is replicated inside the for loop. Can probably abstract it out to return a boolean that represents whether i has to be removed or not. And then calling if(whetherToRemove(fromcolumns) || whetherToRemove(toColumns)) i.remove(); lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java <https://reviews.apache.org/r/28849/#comment107248> if i.remove has already been called in the previous loop then we'll get Illegal State Exception here. - Rajat Khandelwal On Dec. 9, 2014, 12:51 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28849/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2014, 12:51 p.m.) > > > Review request for lens. > > > Bugs: LENS-94 > https://issues.apache.org/jira/browse/LENS-94 > > > Repository: lens > > > Description > ------- > > Fix columns attached to join paths > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 1047352 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 9f6c6a4 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 822a6f5 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > 4299874 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > 492ce68 > > Diff: https://reviews.apache.org/r/28849/diff/ > > > Testing > ------- > > All existing tests pass with the change. Will add more unit tests for cases > the issue is solving > > > Thanks, > > Amareshwari Sriramadasu > >
