> On Dec. 10, 2014, 6:45 a.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java, > > line 363 > > <https://reviews.apache.org/r/28849/diff/1/?file=786823#file786823line363> > > > > Looks like code is replicated inside the for loop. Can probably > > abstract it out to return a boolean that represents whether i has to be > > removed or not. And then calling if(whetherToRemove(fromcolumns) || > > whetherToRemove(toColumns)) i.remove();
Not doing right now, because information for logging would be missed. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28849/#review64509 ----------------------------------------------------------- On Dec. 10, 2014, 11:23 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28849/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2014, 11:23 a.m.) > > > Review request for lens. > > > Bugs: LENS-94 > https://issues.apache.org/jira/browse/LENS-94 > > > Repository: lens > > > Description > ------- > > Fix columns attached to join paths > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 1047352 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 9f6c6a4 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 822a6f5 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > 4299874 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > a4e4535 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > 6f32280 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > 492ce68 > > Diff: https://reviews.apache.org/r/28849/diff/ > > > Testing > ------- > > All existing tests pass with the change. Will add more unit tests for cases > the issue is solving > > > Thanks, > > Amareshwari Sriramadasu > >
