----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28946/#review64820 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/Dimension.java <https://reviews.apache.org/r/28946/#comment107606> Can you include test in TestCubeMetastoreClient to test joinchains in Dimension ? lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java <https://reviews.apache.org/r/28946/#comment107605> Should remove method toCubeToDimRelationship ? lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java <https://reviews.apache.org/r/28946/#comment107610> Method not required? I dont see any callers. Can we remove? lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java <https://reviews.apache.org/r/28946/#comment107603> Is this indentation shift correct? Is it not crossing 120 line length? lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java <https://reviews.apache.org/r/28946/#comment107600> Can you include test in TestMetastoreService to test these changes? lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java <https://reviews.apache.org/r/28946/#comment107601> Would need changes in xdimensionFromDimension to take care of Join chains - Amareshwari Sriramadasu On Dec. 11, 2014, 4:05 p.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28946/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2014, 4:05 p.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-97 > https://issues.apache.org/jira/browse/LENS-97 > > > Repository: lens > > > Description > ------- > > Joinchain support for dimension only queries > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 2a7030f > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java > 5b9c818 > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 7ffb62c > lens-cube/src/main/java/org/apache/lens/cube/metadata/Dimension.java > 4fa3610 > lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java > 0551803 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > f5cc8c8 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 1da7cda > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 3f3079f > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 0c7d181 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > 15fdd6e > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > cea66d1 > > Diff: https://reviews.apache.org/r/28946/diff/ > > > Testing > ------- > > Added 3 UTs > > > Thanks, > > Suma Shivaprasad > >
