> On Dec. 12, 2014, 6:06 p.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java, line > > 296 > > <https://reviews.apache.org/r/28946/diff/3/?file=790148#file790148line296> > > > > `getToCubeOrDimRelationship` ?
renamed to toCubeOrDimRelationship according to Amareshwari's comment > On Dec. 12, 2014, 6:06 p.m., Rajat Khandelwal wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java, > > line 88 > > <https://reviews.apache.org/r/28946/diff/3/?file=790149#file790149line88> > > > > `CUBE_JOIN_CHAIN_KEY` This key is being reused to construct both cube and dimension join chain keys - Suma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28946/#review64934 ----------------------------------------------------------- On Dec. 14, 2014, 4:53 p.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28946/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2014, 4:53 p.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-97 > https://issues.apache.org/jira/browse/LENS-97 > > > Repository: lens > > > Description > ------- > > Joinchain support for dimension only queries > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 2a7030f > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java > 5b9c818 > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java 7ffb62c > lens-cube/src/main/java/org/apache/lens/cube/metadata/Dimension.java > 4fa3610 > lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java > 0551803 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 5df35a5 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > bd95497 > lens-cube/src/main/java/org/apache/lens/cube/parse/AliasReplacer.java > f5cc8c8 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 1da7cda > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 3f3079f > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 5fd1bdd > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 0c7d181 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > 15fdd6e > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > cea66d1 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 11d7171 > > Diff: https://reviews.apache.org/r/28946/diff/ > > > Testing > ------- > > Added 3 UTs > > > Thanks, > > Suma Shivaprasad > >
