> On Dec. 23, 2014, 12:12 p.m., Jaideep dhok wrote: > > src/site/apt/developer/commit.apt, line 79 > > <https://reviews.apache.org/r/29362/diff/1/?file=799440#file799440line79> > > > > Does the person committing also has to rerun all tests? Or is it onus > > of the person submitting the patch?
Committer can ask the contributor to update the test result he ran. Only thing we want to ensure is no tests are broken. Once we have jenkins builds for testing patch available jiras, this should be easy. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29362/#review65929 ----------------------------------------------------------- On Dec. 23, 2014, 12:05 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29362/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 12:05 p.m.) > > > Review request for lens, Jaideep dhok, sharad agarwal, Srikanth Sundarrajan, > and Suma Shivaprasad. > > > Bugs: LENS-112 > https://issues.apache.org/jira/browse/LENS-112 > > > Repository: lens > > > Description > ------- > > Improves contributor doc by adding guidelines for miscellaneous > contributions, quality improvements, documentation guidelines and reviewing > guidelines. > > > Diffs > ----- > > src/site/apt/developer/commit.apt 7067c2b > src/site/apt/developer/contribute.apt 87ab46b > > Diff: https://reviews.apache.org/r/29362/diff/ > > > Testing > ------- > > Validated the doc by running in local. Verified all links work fine. > > > Thanks, > > Amareshwari Sriramadasu > >
