----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29362/#review66002 -----------------------------------------------------------
src/site/apt/developer/commit.apt <https://reviews.apache.org/r/29362/#comment109320> updated earliest* src/site/apt/developer/commit.apt <https://reviews.apache.org/r/29362/#comment109321> Why are these removed. Seems relevant. Moved elsewhere? src/site/apt/developer/contribute.apt <https://reviews.apache.org/r/29362/#comment109322> Remove "Trying to list them here". "following" in the ealier part seems to indicate the same. src/site/apt/developer/contribute.apt <https://reviews.apache.org/r/29362/#comment109323> Though seems miscellaneous, I think this one is not easy for a new comer or a person who is less involved with the project src/site/apt/developer/contribute.apt <https://reviews.apache.org/r/29362/#comment109324> Adding tests is often a good way to learn the system and we should welcome contributions on that front as well. src/site/apt/developer/contribute.apt <https://reviews.apache.org/r/29362/#comment109325> Is the delay in mirroring noticeable ? src/site/apt/developer/contribute.apt <https://reviews.apache.org/r/29362/#comment109326> "then this is not the place to go" should perhaps be "then this is not the place to add them" src/site/apt/developer/contribute.apt <https://reviews.apache.org/r/29362/#comment109327> Ah!. It looks like the review guidelines have simply been moved. thanks src/site/apt/developer/contribute.apt <https://reviews.apache.org/r/29362/#comment109328> Some of this is repeat of what is mentioned in DeveloperMenu (perhaps it need to be removed from there) - Srikanth Sundarrajan On Dec. 23, 2014, 12:05 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29362/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2014, 12:05 p.m.) > > > Review request for lens, Jaideep dhok, sharad agarwal, Srikanth Sundarrajan, > and Suma Shivaprasad. > > > Bugs: LENS-112 > https://issues.apache.org/jira/browse/LENS-112 > > > Repository: lens > > > Description > ------- > > Improves contributor doc by adding guidelines for miscellaneous > contributions, quality improvements, documentation guidelines and reviewing > guidelines. > > > Diffs > ----- > > src/site/apt/developer/commit.apt 7067c2b > src/site/apt/developer/contribute.apt 87ab46b > > Diff: https://reviews.apache.org/r/29362/diff/ > > > Testing > ------- > > Validated the doc by running in local. Verified all links work fine. > > > Thanks, > > Amareshwari Sriramadasu > >
