> On Dec. 30, 2014, 11:29 a.m., Suma Shivaprasad wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java, line > > 22 > > <https://reviews.apache.org/r/29451/diff/4/?file=803250#file803250line22> > > > > pls add documentation and update lens-examples and on how this can be > > used in cube xsd.
Hi Suma, that will be part of LENS-176 - Jaideep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29451/#review66354 ----------------------------------------------------------- On Dec. 30, 2014, 6:45 a.m., Jaideep dhok wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29451/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2014, 6:45 a.m.) > > > Review request for lens. > > > Bugs: LENS-175 > https://issues.apache.org/jira/browse/LENS-175 > > > Repository: lens > > > Description > ------- > > Changes in ExprColumn and test changes to validate multiple expressions. No > changes required in CubeMetastoreClient > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java > 352fef9 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > c51f0ba > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 48c5fbb > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7347b3a > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 5889506 > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java > PRE-CREATION > lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java > 760aaab > > Diff: https://reviews.apache.org/r/29451/diff/ > > > Testing > ------- > > Added new tests for creating and altering multiple expressions. > No impact on existing lens-cube tests. I'll update JIRA with complete test > report. > > > Thanks, > > Jaideep dhok > >
