-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29451/
-----------------------------------------------------------

(Updated Dec. 30, 2014, 5:40 a.m.)


Review request for lens.


Changes
-------

Removed lowercasing of expressions.
Updated equals and hashcode to consider lower case tokens.


Bugs: LENS-175
    https://issues.apache.org/jira/browse/LENS-175


Repository: lens


Description
-------

Changes in ExprColumn and test changes to validate multiple expressions. No 
changes required in CubeMetastoreClient


Diffs (updated)
-----

  lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java 352fef9 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7347b3a 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
 5889506 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/TestExprColumn.java 
PRE-CREATION 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 760aaab 

Diff: https://reviews.apache.org/r/29451/diff/


Testing
-------

Added new tests for creating and altering multiple expressions. 
No impact on existing lens-cube tests. I'll update JIRA with complete test 
report.


Thanks,

Jaideep dhok

Reply via email to